Repository navigation
fix(nuxt): sync i18n locale reactively using dependsOn - #16
Merged
Merged
Conversation
javipuche
force-pushed
the
fix/sync-i18n-timing
branch
from
March 10, 2026 10:41
5499bc3 to
5044b11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem\n\nWhen using Valiform with
@nuxtjs/i18n, the locale was not updating reactively when switching languages. The root cause was a plugin initialization order issue: Valiform's Nuxt plugin was running before@nuxtjs/i18nhad registerednuxtApp.$i18n, so$i18nwasundefinedat setup time.\n\n## Solution\n\nSplit the Nuxt runtime plugin into two variants:\n-plugin.ts— used when@nuxtjs/i18nis not installed\n-plugin-i18n.ts— used when@nuxtjs/i18nis installed; declaresdependsOn: ['i18n:plugin']so Nuxt guarantees$i18nis ready before Valiform runs\n\nThe module (nuxt/module.ts) dynamically selects which plugin to register usinghasNuxtModule('@nuxtjs/i18n')from@nuxt/kit. This ensures Valiform works correctly in both scenarios without breaking projects that don't use i18n.\n\nShared setup logic was extracted tonuxt/runtime/setup.tsto avoid duplication.